#502 Clean up cartoon workflow chrome and action hierarchy#511
Conversation
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #511 on the current live head. The change matches issue #502 by demoting the global workflow chrome to one non-intrusive floating CTA while moving route-specific primary actions and readiness context into the Story Info and Episodes surfaces themselves.
Findings
- No blocking findings.
Decision
Approved. StoriesPage removes the old full-width footer CTA strip in favor of a compact bottom-right shell overlay, StoryInfoPage now leads with metadata readiness plus Save Story Info near the top of the route, and EpisodesPage opens with an immediate readiness summary before the episode list. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #511 on live head ca3b4a11ab2a70ba8170138d92cc4fa955dad87d. The change removes the full-width global Next Action strip, keeps route-specific actions closer to their content, and improves Story Info and Episodes first-screen hierarchy.
Findings
- No blocking findings.
Decision
Approved on GitHub. The cartoon shell now uses a bottom-right Next Action overlay instead of a route footer strip, Story Info has header-level readiness chips plus Save Story Info, Episodes now opens with compact sequence/readiness counts, and the previously compacted Progress/Publish/episode surfaces remain in place. Live lint-and-typecheck passes.
2 participants
Summary
Next Actionoverlay instead of a full-width route footer stripSave Story Infointo the Story Info page header and surface compact readiness chips so that route leads with metadata + cover controlsTesting
npm run typechecknpm run lint -- --quiet app/web/components/StoriesPage.tsx app/web/components/StoriesPage.test.tsx app/web/components/StoryInfoPage.tsx app/web/components/StoryInfoPage.test.tsx app/web/components/EpisodesPage.tsx app/web/components/EpisodesPage.test.tsxnpm run app:buildnpx vitest run --coverage.enabled=false app/web/components/StoriesPage.test.tsx app/web/components/StoryInfoPage.test.tsx app/web/components/EpisodesPage.test.tsx(fails before collection in this environment withUnknown system error -122, write)Visual QA
1440x900: the globalNext Actionis now a floating bottom-right overlay instead of a full-width bottom strip, so route content keeps a clearer first-screen purpose and more vertical space1440x900: Story Info now opens with title/metadata/cover readiness chips andSave Story Infoin the header area rather than making the primary save action live at the bottom of the form1440x900: Episodes now starts with a compact total/active/published/ready summary above the episode list so sequence/readiness context is visible immediatelyRisks